• 3
name

A PHP Error was encountered

Severity: Notice

Message: Undefined index: userid

Filename: views/question.php

Line Number: 191

Backtrace:

File: /home/prodcxja/public_html/questions/application/views/question.php
Line: 191
Function: _error_handler

File: /home/prodcxja/public_html/questions/application/controllers/Questions.php
Line: 433
Function: view

File: /home/prodcxja/public_html/questions/index.php
Line: 315
Function: require_once

name Punditsdkoslkdosdkoskdo

Android Studio debugger highlights the wrong lines

I can't see anything functionally wrong in terms of what gets executed, but I've just wasted an hour proving my code and the compiler are doing what they're supposed to.

Consider this code:

public int getAnswer(int a) {

    int retval = 18;

    int x = 25;
    int y = 50;

    while (a-- > 0) {
        if (a == 3) {
            retval = a;
            return retval;
        }
    }

    x = 10;
    y = 20;

    return 0;
}

Called with

int theAnswer = getAnswer(6);

Breakpoint both of the lines containing return and before you run the code, try and predict the result, and therefore which line will be hit.

As you might imagine from the tone of my question, the wrong line is highlighted, but the right result is returned. If you step through the code, it dances around quite a bit.

Is there anything that can be configured differently such that the correct lines are displayed? (I'm using the latest Android Studio, which I appreciate is potentially unstable, but I'm sure I've seen similar behaviour on Eclipse a while back but I never spent the time then tracking it down; perhaps it's a java thing).

This is a problem with dx, which is the part of the build that turns your Java .class files into .dx files for packaging into Android. According to this:

https://code.google.com/p/android/issues/detail?id=34193

if a function has multiple return paths, dx merges the return instruction into a single return instruction, so during debugging, the debugger can't tell which line a return belongs to and things jump around. This corresponds to what I see when I try to reproduce your problem: each time through the loop it does the if (a == 3) check, jumps to the return 0 at the end, and then jumps back into the loop. You're seeing that last return 0 get merged with the return retval in the middle of the loop.

I doubt this will be fixed any time soon, so you may just have to learn to live with it. Sorry, I know it's kinda crazy.

  • 44
Reply Report
    • It's not an optimization. It's the binary format for the Dalvik VM; you can't run .class files directly on Android.
      • 2
    • Not dx itself; I mean couldn't it create multiple return instructions, as in the source code?
    • I have suffered through this as well... I understand there is a "reason" for it, but it is simply unacceptable. It is a serious design problem in dx that needs to be addressed. iOS and other mobile platforms do not have such an issue that makes life very difficult for developers

Try Build -> Rebuild project and then Shift + F9. You have outdated code running on application.

  • 2
Reply Report
      • 2
    • I'm using intellij IDEA(which is the same) for several years for android development, and the issue you described appeared to me only when i faced outdated code. Maybe you are debugging library code? If not, then sorry i don't know what's wrong you may do.
      • 1
    • No, I literally just create a new test Android project using Android studio, cut and paste the code about into it and call it from onCreate and it behaves exactly the same way every time.
      • 1
    • No, it's not that. Cleaned, rebuilt, remade, moved code around a little just for the sake of it too - no difference. I created a new test project just to check it, and I'm running it on an actual device, not an emulator. Try it!

Here's what worked for me, at least for stepping into Android SDK source code:

  1. Install the SDK Platform and Sources for Android SDK for exactly the API level of the version of Android you are running during development (use the Android version history page to find out which API level your device has).
  2. Compile your app for exactly that version. For example, in Android Studio, open your app's build.gradle file and set the value of compileSdkVersion accordingly.
  3. Debug your app. When you step into Android SDK source, you should see the correct line.
  4. (optional) Recompile with the latest SDK before deploying. In other words, change compileSdkVersion back.
  • 2
Reply Report
      • 2
    • This works for none SDK code too. I switched my min API version to match my target device and now the debugger is showing the correct lines.